Review 11.5 Merged

73088[BUGFIX] Avoid undefined array key 'casesensitiveComp'

Benni Mack CR +2 V +2 Easy +4 −1 updated 01/22/22, 13:12

Commit message

Using null coalescing operator with fallback to 'false'
to avoid undefined array key access warnings when key
'casesensitiveComp' is not set. Using 'false' here as
this matches the behaviour of <PHP8.0, and as this is
used as method argument of type bool a bool typecase
is added along the way to be on the safe side.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 01/22/22, 12:34

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/22/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22405

  3. Benni Mack voted on patch set 1 V +2 CR +2 01/22/22, 13:12

  4. Benni Mack merged patch set 2 01/22/22, 13:12