Review 11.5 Merged

73155[BUGFIX] Remove undefined variable in extensionmanager ListUtility

Helmut Hummel CR +2 V +2 Easy +5 −9 updated 02/05/22, 09:44

Commit message

Fixing an issue with package informations to list extensions for
the cli command 'extension:list' code has been moved  #95693, which
left over an undefined variable at the new place. This has been
undetected and not failed because of a used 'null coalescing operator'
with a default value as fallback.

However well configured static code analysers may struggle with this
and emiting errors, we will remove this undefined variable here as
which should be fine. Additional enriching emconf information has
been adjusted to always include the state, which required to adjust
corresponding unit tests for it.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 911

  1. Helmut Hummel commented on patch set 1 01/25/22, 09:23

    Cherry Picked from branch main.
  2. Helmut Hummel voted on patch set 1 V +2 CR +2 01/25/22, 09:23

  3. core-ci voted on patch set 1 V +1 01/25/22, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22507

  4. Oliver Klee voted on patch set 1 CR +1 01/25/22, 12:07

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 01/25/22, 12:21

  6. Daniel Haupt voted on patch set 1 CR +1 01/26/22, 01:40

  7. Christian Kuhn uploaded patch set 2 02/05/22, 09:25

  8. Christian Kuhn commented on patch set 1 02/05/22, 09:25

    needs a rebase since this now fixes a phpstan error. will merge when green.
  9. core-ci voted on patch set 2 V +1 02/05/22, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23046

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 02/05/22, 09:44

  11. Christian Kuhn merged patch set 3 02/05/22, 09:44