Review 11.5 Merged

73156[TASK] Extend .phpstorm.meta.php for further autocompletion support

Benni Mack CR +2 V +2 Normal +51 −0 updated 01/25/22, 11:50

Commit message

Extend PHPStorm meta file with further definitions for autocompletion
support and avoid unnecessary php docblocks in the code base.

* add request getAttribute() return types
* add return type for 'SiteMatcher->matchRequest()'
* add return type for 'PageRouter->matchRequest()'

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 01/25/22, 09:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/25/22, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22508

  3. Benni Mack voted on patch set 1 V +2 CR +2 01/25/22, 11:50

  4. Benni Mack merged patch set 2 01/25/22, 11:50