Review 11.5 Merged

73164[BUGFIX] Correctly calculate bit-masks in JavaScriptModuleInstruction

Benjamin Franzke CR +2 V +2 Easy +49 −1 updated 01/28/22, 14:26

Commit message

Method JavaScriptModuleInstruction::addFlags used plain arithmetic
calculation on bit-masks. In case corresponding flags were just
given once, that would not have lead to problems. However, enabling
the same bits multiple times would have lead to side-effects
like disabling the added bit or enabling others.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 01/28/22, 13:13

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/28/22, 13:19

  3. core-ci voted on patch set 1 V +1 01/28/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22624

  4. Benjamin Franzke merged patch set 2 01/28/22, 14:26