Review 11.5 Merged

73283[TASK] Tighten composer integration validation script

Benni Mack CR +2 V +2 Easy +11 −0 updated 02/07/22, 09:54

Commit message

The script "Build/Scripts/checkIntegrityComposer.php"
verifies composer.json dependencies of each system
extension to have the same version as the root composer.json
manifest file.

The patch adds an additional check that all dependencies
of a system extension also have a counterpart
in the main root composer.json of the development collection.

This way, we avoid scenarios where we remove a dependency from
the root composer.json and forget to remove it from system
extensions, too.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 02/07/22, 09:40

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/07/22, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23128

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 02/07/22, 09:54

  4. Christian Kuhn merged patch set 2 02/07/22, 09:54