Review 11.5 Merged

73532[BUGFIX] Ignore deleted l10n_source records when translating

Benni Mack CR +2 V +2 Easy +32 −5 updated 02/15/22, 11:43

Commit message

If l10n_source points to a deleted or non-existing record the
translation wizard failed in free mode with a 500 error,
because determining the source languages fail and no fallback was
implemented. Instead of failing, the behaviour was adjusted to
handle l10n_source pointing to erroneous records similarly to an
empty column and offering all available language as option for
the translation - as in fact the source cannot be reliably determined.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Benni Mack commented on patch set 1 02/15/22, 11:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/15/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23612

  3. Benni Mack voted on patch set 1 V +2 CR +2 02/15/22, 11:43

  4. Benni Mack merged patch set 2 02/15/22, 11:43