Review 11.5 Merged

73543[BUGFIX] Replace wrong routeIdentifier in example code

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 02/17/22, 23:49

Commit message

Some code examples for the ShortcutButton
"routeIdentifier" property, introduced in #93093,
used the non existing "web_view" identifier.

Using this code example will therefore lead to
a RouteNotFoundException exception.

This is now fixed by using the correct identifier
for the viewpage module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 35

  1. Oli Bartsch commented on patch set 1 02/17/22, 23:15

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 02/17/22, 23:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23844

  3. core-ci voted on patch set 1 V +1 02/17/22, 23:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23844

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 02/17/22, 23:49

  5. Oli Bartsch merged patch set 2 02/17/22, 23:49