Review 10.4 Merged

73652[BUGFIX] Check for complete database configuration before connecting

Benni Mack CR +2 V +2 Easy +1 −1 updated 02/22/22, 20:49

Commit message

Install tool has been trying to connect to the database before
checking if a bare minimum of configuration is given to. This has
been done to decide if the database connect step needs to be shown.

Starting with php8.1 this fails hard and the step is not shown,
thus an installation cannot be finished.

This patch change the checking order and checks for the bare minimum of
configuration first, before try to connect to the database.

Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d sqlite
Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d mariadb
Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d mysql

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 02/22/22, 20:32

    Cherry Picked from branch master.
  2. Stefan Bürk voted on patch set 1 V +1 CR +1 02/22/22, 20:36

  3. core-ci voted on patch set 1 V +1 02/22/22, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24064

  4. Benni Mack voted on patch set 1 V +2 CR +2 02/22/22, 20:49

  5. Benni Mack merged patch set 2 02/22/22, 20:49