Review 11.5 Merged

73653[BUGFIX] Add missing comma to array_merge() in WorkspaceService

Benni Mack CR +2 V +2 Easy +1 −1 updated 02/24/22, 19:49

Commit message

With deprecating 3rd party usage of getTreeList() in
QueryGenerator and QueryView with #92080 a comma has
been missed as element list separator for a list merge
with array_merge(...) in WorkspaceService. This emits
a corresponding native PHP warning or error.

Missing comma is added to avoid the warning and merge
the elements properly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Gerdes +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Gerdes +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 02/24/22, 09:08

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/24/22, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24165

  3. Markus Gerdes voted on patch set 1 V +1 CR +1 02/24/22, 19:39

  4. Benni Mack voted on patch set 1 V +2 CR +2 02/24/22, 19:49

  5. Benni Mack merged patch set 2 02/24/22, 19:49