Review 11.5 Merged

73658[BUGFIX] Avoid deprecation in PHP 8.1 passing null value to HtmlViewHelper

Benni Mack CR +2 V +2 Hard +283 −1 updated 03/07/22, 08:18

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1116

  1. Benni Mack commented on patch set 1 02/24/22, 20:08

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php * typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlViewHelperTest.php
  2. Benni Mack commented on patch set 2 02/24/22, 20:12

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 02/24/22, 20:12

  4. Benni Mack commented on patch set 3 02/24/22, 20:12

    Published edit on patch set 2.
  5. core-ci voted on patch set 2 V -1 02/24/22, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24230

  6. core-ci voted on patch set 3 V -1 02/24/22, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24231

  7. core-ci voted on patch set 1 V -1 02/24/22, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24229

  8. Stefan Bürk uploaded patch set 4 02/24/22, 21:16

  9. core-ci voted on patch set 4 V -1 02/24/22, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24235

  10. Stefan Bürk uploaded patch set 5 03/06/22, 12:14

  11. core-ci voted on patch set 5 V +1 03/06/22, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24638

  12. Stefan Bürk commented on patch set 5 V +1 CR +1 03/06/22, 12:32

    changes to make backport ci tests happy: * removed test cases for new v12 feature not existing in v11 (new viewhelper arguments). * changed expectation for invalid test case to test for the deprecation instead of the v12 logic exception. * additionally added the deprecated functionality as deprecated functional tests to ensure funtionality still works even when trigger deprecation log entries. this was needed, as tests for the format html viewhelper did not existed before in v11.
  13. Oliver Klee voted on patch set 5 CR +1 03/06/22, 12:47

  14. Benni Mack commented on patch set 5 03/07/22, 08:17

    Thanks for taking care.
  15. Benni Mack voted on patch set 5 V +2 CR +2 03/07/22, 08:17

  16. Benni Mack merged patch set 6 03/07/22, 08:18