Review 11.5 Merged

73783[TASK] Move TS condition check to TS condition matcher

Helmut Hummel CR +2 V +2 Normal +25 −32 updated 03/07/22, 15:19

Commit message

The ExpressionLanguageResolver should be generic and not
implement some TypoScript related logic.

Therefore the check for "ELSE" expression is moved to
AbstractConditionMatcher

Dead code is removed on the go.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 46

  1. Helmut Hummel commented on patch set 1 03/05/22, 20:32

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 03/05/22, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24628

  3. Helmut Hummel uploaded patch set 2 03/07/22, 15:02

  4. core-ci voted on patch set 2 V +1 03/07/22, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24663

  5. Helmut Hummel voted on patch set 2 V +2 CR +2 03/07/22, 15:19

  6. Helmut Hummel merged patch set 3 03/07/22, 15:19