Review 11.5 Merged

73873[BUGFIX] Unify handling of reading from sys_log.log_data

Benni Mack CR +2 V +2 Normal +144 −44 updated 03/09/22, 17:43

Commit message

This change allows using PSR-3 provided placeholders
such as "{myVariable}" in various places related to logging
rendering, and fixes places in DataHandler where
placeholders weren't used in the past and hard-coded
strings were used instead of labels.

Various logging calls to sys_log can now be read in
a unified way, as the Logging API already used the
placeholders in some places.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1014

  1. Benni Mack commented on patch set 1 03/09/22, 11:32

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php
  2. Benni Mack commented on patch set 2 03/09/22, 11:32

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 03/09/22, 11:33

  4. core-ci voted on patch set 1 V -1 03/09/22, 11:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24739

  5. core-ci voted on patch set 2 V -1 03/09/22, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24740

  6. Stefan Bürk commented on patch set 2 03/09/22, 15:51

    LogDataTrait.php:30

    must be removed and added as docblock (php 8.0 min req)

    LogDataTrait.php:33

    (string) cast should be wise, as argument type is mixed

    LogDataTrait.php:35

    (string) cast should be wise, as argument type is mixed

    LogDataTrait.php:43

    must be removed and added as docblock (php 8.0 min req)
  7. Benni Mack commented on patch set 3 03/09/22, 17:14

    Published edit on patch set 2.
  8. Benni Mack commented on patch set 3 03/09/22, 17:14

    LogDataTrait.php:30 Reply

    Done

    LogDataTrait.php:33 Reply

    Done

    LogDataTrait.php:35 Reply

    Done

    LogDataTrait.php:43 Reply

    Done
  9. core-ci voted on patch set 3 V -1 03/09/22, 17:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24757

  10. Stefan Bürk uploaded patch set 4 03/09/22, 17:33

  11. core-ci voted on patch set 4 V +1 03/09/22, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24760

  12. Stefan Bürk voted on patch set 4 V +1 CR +1 03/09/22, 17:42

  13. Benni Mack voted on patch set 4 V +2 CR +2 03/09/22, 17:43

  14. Benni Mack merged patch set 5 03/09/22, 17:43