73873[BUGFIX] Unify handling of reading from sys_log.log_data
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Security/FailedLoginAttemptNotification.php+4 −2
- typo3/sysext/belog/Classes/Domain/Model/LogEntry.php+5 −5
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php+3 −7
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+25 −25
- typo3/sysext/core/Classes/Log/LogDataTrait.php8new+78 −0
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+3 −2
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+17 −0
- typo3/sysext/lowlevel/Classes/Command/ListSysLogCommand.php+5 −2
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+4 −1
Review log 1014
-
Benni Mack commented on patch set 1 03/09/22, 11:32
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php -
Benni Mack commented on patch set 2 03/09/22, 11:32
Published edit on patch set 1. -
Benni Mack marked it ready for review 03/09/22, 11:33
-
core-ci voted on patch set 1 V -1 03/09/22, 11:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24739
-
core-ci voted on patch set 2 V -1 03/09/22, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24740
-
Stefan Bürk commented on patch set 2 03/09/22, 15:51
LogDataTrait.php:30must be removed and added as docblock (php 8.0 min req)LogDataTrait.php:33(string) cast should be wise, as argument type is mixedLogDataTrait.php:35(string) cast should be wise, as argument type is mixedLogDataTrait.php:43must be removed and added as docblock (php 8.0 min req) -
Benni Mack commented on patch set 3 03/09/22, 17:14
Published edit on patch set 2. -
Benni Mack commented on patch set 3 03/09/22, 17:14
LogDataTrait.php:30ReplyDoneLogDataTrait.php:33ReplyDoneLogDataTrait.php:35ReplyDoneLogDataTrait.php:43ReplyDone -
core-ci voted on patch set 3 V -1 03/09/22, 17:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24757
-
Stefan Bürk uploaded patch set 4 03/09/22, 17:33
-
core-ci voted on patch set 4 V +1 03/09/22, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24760
-
Stefan Bürk voted on patch set 4 V +1 CR +1 03/09/22, 17:42
-
Benni Mack voted on patch set 4 V +2 CR +2 03/09/22, 17:43
-
Benni Mack merged patch set 5 03/09/22, 17:43