Review 11.5 Merged

73878[BUGFIX] Use sys_history for workspaces stage changes + comments

Benni Mack CR +2 V +2 Normal +129 −37 updated 03/14/22, 13:41

Commit message

Historically, a stage change
(publishing or "editing => ready to publish") has been
tracked - along with the comment in sys_log with the
action=6 (update) and details_nr=30, where then the logs
are read again for the workspaces module.

Reading from sys_log is a problem as this data is
very volatile (there is even a scheduler task to delete
old sys_log entries older than e.g. 90 days, so we loose
comments).

This change now stores the information inside the
sys_history table about a stage change, so the history
of such an action is preserved, along with the comment.

The workspaces module now reads from sys_history (via
RecordHistory class) and from sys_log if there are
still old comments.

The reading from sys_log can then be removed at a later
change.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 57

  1. Benni Mack commented on patch set 1 03/14/22, 12:42

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/workspaces/backend.ts * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js
  2. core-ci voted on patch set 1 V -1 03/14/22, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24877

  3. Benni Mack uploaded patch set 2 03/14/22, 13:07

  4. Benni Mack marked it ready for review 03/14/22, 13:07

  5. core-ci voted on patch set 2 V +1 03/14/22, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24882

  6. Benni Mack voted on patch set 2 V +2 CR +2 03/14/22, 13:41

  7. Benni Mack merged patch set 3 03/14/22, 13:41