Review 11.5 Merged

74297[BUGFIX] Fix type annotation of HistoryService::differencesObject

Benni Mack CR +2 V +2 Easy +1 −6 updated 04/15/22, 20:18

Commit message

This field actually is nullable and needs to be annotated accordingly.

This change fixes a PHPStan warning.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Benni Mack commented on patch set 1 04/14/22, 20:52

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon
  2. Benni Mack commented on patch set 2 04/14/22, 20:53

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 04/14/22, 20:53

  4. Oliver Klee voted on patch set 2 CR +1 04/14/22, 20:58

  5. core-ci voted on patch set 1 V -1 04/14/22, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26034

  6. core-ci voted on patch set 2 V -1 04/14/22, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26035

  7. Benni Mack commented on patch set 3 04/14/22, 21:55

    Published edit on patch set 2.
  8. Benni Mack commented on patch set 4 04/14/22, 21:56

    Published edit on patch set 3.
  9. core-ci voted on patch set 3 V +1 04/14/22, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26039

  10. core-ci voted on patch set 4 V +1 04/14/22, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26040

  11. Oliver Klee voted on patch set 4 V +1 CR +1 04/14/22, 22:17

  12. Benni Mack voted on patch set 4 V +2 CR +2 04/15/22, 20:18

  13. Benni Mack merged patch set 5 04/15/22, 20:18