Review 11.5 Merged

74302[TASK] Migrate form-horizontal class to Bootstrap 5

Benni Mack CR +2 V +2 Normal +57 −65 updated 04/18/22, 10:58

Commit message

This patch migrates the "form-horizontal" class from
Bootstrap 3 to the new style by using the "row" and
"col-form-label" classes.

Usages of form-group have also been replaced by the
utility "mb-3" class. This allowed to drop one Css
rule for removing the margin of the last element in
the LinkBrowser.

Places adjusted:
* Settings > Presets
* Form > Duplicate
* LinkBrowser
* ExtensionManager > Upload extension

Some places have already been migrated, but forgot
to remove the class.

In addition, the id "typo3-linkURL" has been removed
along the way, as the styling was removed in #71840
already.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 20

Review log 68

  1. Benni Mack commented on patch set 1 04/17/22, 22:49

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/Css/backend.css * typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js
  2. Benni Mack uploaded patch set 2 04/17/22, 22:54

  3. Benni Mack marked it ready for review 04/17/22, 22:54

  4. core-ci voted on patch set 1 V -1 04/17/22, 23:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26130

  5. core-ci voted on patch set 2 V +1 04/17/22, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26131

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 04/18/22, 09:00

  7. Benni Mack voted on patch set 2 V +2 CR +2 04/18/22, 10:58

  8. Benni Mack merged patch set 3 04/18/22, 10:58