74353[BUGFIX] Avoid returning invalid return type in AbstractOEmbedHelper
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2629
Show 34 earlier messages
-
Florian Rival uploaded patch set 1 04/19/22, 09:37
-
core-ci voted on patch set 1 V -1 04/19/22, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26177
-
Oliver Klee commented on patch set 1 04/19/22, 10:24
-
Christian Efthimoglou commented on patch set 1 V +1 CR +1 04/27/22, 12:01
Works for me with TYPO3 11.5.9.
-
Oliver Klee commented on patch set 1 CR -1 04/27/22, 12:26
VimeoHelper.php:57We need to fix the indentation of this block of code. (And there also seems to be a tab in the first changed line.) -
Florian Rival commented on patch set 2 04/27/22, 13:59
Published edit on patch set 1. -
core-ci voted on patch set 2 V -1 04/27/22, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26511
-
Florian Rival commented on patch set 2 04/27/22, 14:13
AbstractOEmbedHelper.php:64ReplyNo because json_decode can return NULL, true or false.VimeoHelper.php:57ReplyDone -
Oliver Klee commented on patch set 2 04/27/22, 14:13
VimeoHelper.php:53Do we also need to check whether $oEmbedData['thumbnail_url'] isset?VimeoHelper.php:57ReplyDone -
Oliver Klee commented on patch set 2 04/27/22, 14:26
AbstractOEmbedHelper.php:64ReplyDone -
Florian Rival commented on patch set 2 04/27/22, 14:30
Don't know if it's necessary but should be better. I've done it. -
Christian Efthimoglou voted on patch set 2 V +1 CR +1 04/28/22, 07:47
-
Oli Bartsch commented on patch set 2 04/28/22, 10:45
AbstractOEmbedHelper.php:64What do you think about ensuring the currently declared return types instead of adding even more? -
Oliver Klee commented on patch set 2 04/28/22, 11:56
AbstractOEmbedHelper.php:64ReplyI'd be fine either way, but would prefer ensuring the declared types. -
Oli Bartsch commented on patch set 2 05/04/22, 21:06
AbstractOEmbedHelper.php:90This is a change in behaviour because the if is true as soon as $oEmbed is an array, even if it's an empty array. -
Oli Bartsch commented on patch set 2 05/04/22, 21:07
AbstractOEmbedHelper.php:50Since we only access $embed['title'] in the magic "empty()" method, the is_array check is superfluous. -
Stefan Bürk uploaded patch set 3 05/04/22, 21:07
-
Oli Bartsch commented on patch set 2 05/04/22, 21:08
VimeoHelper.php:53ReplyActually I would just check for this field being not empty, like done for the "title" property in transformMediaIdToFile(). -
Stefan Bürk uploaded patch set 4 05/04/22, 21:20
-
Stefan Bürk uploaded patch set 5 05/04/22, 21:23
-
Stefan Bürk updated the commit message in patch set 6 05/04/22, 21:25
-
Oliver Klee voted on patch set 6 CR +1 05/04/22, 21:27
-
Stefan Bürk uploaded patch set 7 05/04/22, 21:30
-
Stefan Bürk commented on patch set 7 05/04/22, 21:32
cancelled pipeline runs for patchset 3 to 6 .. so do not wonder why votings are missing for them. -
Oliver Klee voted on patch set 7 CR +1 05/04/22, 21:37
-
core-ci voted on patch set 7 V +1 05/04/22, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26848
-
Oli Bartsch commented on patch set 7 V +1 CR +1 05/04/22, 21:41
AbstractOEmbedHelper.php:50ReplyDoneAbstractOEmbedHelper.php:64ReplyDoneAbstractOEmbedHelper.php:90ReplyDoneVimeoHelper.php:53ReplyDone -
Stefan Bürk voted on patch set 7 V +2 CR +2 05/04/22, 21:43
-
Stefan Bürk merged patch set 8 05/04/22, 21:43
AbstractOEmbedHelper.php:64