Issue Bug Closed

#97428PHP Warning: Trying to access array offset on value of type bool in VimeoHelper.php

Florian Rival 04/19/22, 09:00 updated 10/04/22, 14:19

Description

If you browse folder through backend File module with a folder containing a viemo file wich doesn’t exists anymore – or with a wrong ID – you have this error :

(1/1) #1476107295 TYPO3\CMS\Core\Error\Exception
PHP Warning: Trying to access array offset on value of type bool in typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/VimeoHelper.php line 54

How to reproduce :
1. Add a vimeo video file with File module
2. Change the data in Vimeo file in order to have a wrong Vimeo ID
3. In Maintenance module , remove temporary assets in /fileadmin/_processed_
4. In module ‘File’ browse the directory with the wrong Vimeo ID

This problem appears because method AbstractOEmbedHelper::getOEmbedData() can return a value ‘ array|bool|null ‘ and bool and null value are not checked.

This bug only happen with PHP V8.

Reviews 2

History 210

  1. Gerrit Code Review pushed patch set 1 for main to change 74353 status New Under Review 04/19/22, 09:38

  2. Gerrit Code Review pushed patch set 2 for main to change 74353 04/27/22, 13:59

  3. Gerrit Code Review pushed patch set 3 for main to change 74353 05/04/22, 21:07

  4. Gerrit Code Review pushed patch set 4 for main to change 74353 05/04/22, 21:20

  5. Gerrit Code Review pushed patch set 5 for main to change 74353 05/04/22, 21:23

  6. Gerrit Code Review pushed patch set 6 for main to change 74353 05/04/22, 21:25

  7. Gerrit Code Review pushed patch set 7 for main to change 74353 05/04/22, 21:30

  8. Gerrit Code Review pushed patch set 1 for 11.5 to change 74467 05/04/22, 21:43

  9. Florian Rival commented and changed status Under Review Resolved done 0 % 100 % 05/04/22, 21:45

    Applied in changeset commit:ae00ad424a1b04ab30712d4558acab276396cb13.

  10. Benni Mack changed status Resolved Closed 10/04/22, 14:19