Review 11.5 Merged

74468[TASK] Simplify a condition in the workspaces DataHandlerHook

Stefan Bürk CR +2 V +2 Easy +1 −6 updated 05/05/22, 10:57

Commit message

a || (b && !a)

can be simplified to

a || b

(because the second sub-condition is only evaluated if a is false).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Stefan Bürk commented on patch set 1 05/05/22, 10:36

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 V +1 CR +1 05/05/22, 10:56

  3. core-ci voted on patch set 1 V +1 05/05/22, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26878

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 05/05/22, 10:56

  5. Stefan Bürk merged patch set 2 05/05/22, 10:57