Review 11.5 Merged

74470[BUGFIX] Remove "overflow: hidden" from form-wizards-element

Nikita Hovratov CR +2 V +2 Easy +2 −6 updated 05/06/22, 13:45

Commit message

In order to fix select fields overflowing into each other
when they have very long option titles, the CSS rule
"overflow: hidden" has been added. As it seems, this wasn't
even necessary as the rule "min-width: 120px" already does
the trick.

The CSS rule "overflow: hidden" is now removed, which
enables the accessibility box-shadows from bootstrap 5
again.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 58

  1. Nikita Hovratov commented on patch set 1 05/06/22, 13:05

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/Element/ColorElement.php * typo3/sysext/backend/Resources/Public/Css/backend.css
  2. core-ci voted on patch set 1 V -1 05/06/22, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26914

  3. Nikita Hovratov uploaded patch set 2 05/06/22, 13:19

  4. core-ci voted on patch set 2 V -1 05/06/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26916

  5. Nikita Hovratov uploaded patch set 3 05/06/22, 13:34

  6. core-ci voted on patch set 3 V +1 05/06/22, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26917

  7. Nikita Hovratov commented on patch set 3 V +2 CR +2 05/06/22, 13:43

    This change is ready for review.
  8. Nikita Hovratov merged patch set 4 05/06/22, 13:45