Review main Abandoned

74680[BUGFIX] Load only LIVE records in checkIfPageIsHidden

TYPO3com CR 0 V 0 Easy +2 −1 updated 01/20/25, 12:12

Commit message

The `checkIfPageIsHidden` queries the page and afterwards performs the
workspace overlay.
However the first query can also load workspaced records, because the
restriction is missing, which means changes in the workspace can affect
the preview functionality of LIVE.
Most of the time this won't break, because of the `LIMIT 1` and normally
in the database the WS records will be stored after the LIVE record.

We first identified this bug in TYPO3 v10, where this bug is in
`TypoScriptFrontendController`:
https://github.com/TYPO3/typo3/blob/11.5/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php#L852
There you can see there is a check for `pid > 0` in the query which is the
legacy way of saying "no workspace version".

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 914

  1. TYPO3com uploaded patch set 1 05/18/22, 14:06

  2. core-ci voted on patch set 1 V -1 05/18/22, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27301

  3. Nikita Hovratov uploaded patch set 2 07/16/22, 21:29

  4. core-ci voted on patch set 2 V -1 07/16/22, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29305

  5. Nikita Hovratov uploaded patch set 3 07/16/22, 22:06

  6. core-ci voted on patch set 3 V +1 07/16/22, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29307

  7. Oliver Klee commented on patch set 3 07/17/22, 07:16

    We should cover this with a functional regression test.
  8. Oliver Klee voted on patch set 3 CR -1 07/17/22, 07:43

  9. Benni Mack updated the commit message in patch set 4 CR -1 V +1 05/03/23, 09:51

  10. Benni Mack rebased onto patch set 5 07/08/23, 12:03

  11. core-ci voted on patch set 5 V +1 07/08/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43942

  12. Benni Mack updated the commit message in patch set 6 V +1 10/18/24, 14:08

  13. Sebastian Michaelsen commented on patch set 6 01/20/25, 12:08

    Can't reproduce the issue anymore. As the author I'd like to abandon this change.
  14. Christian Kuhn abandoned the change 01/20/25, 12:12

    abandoning as requested by author.