#97654[BUGFIX] Load only LIVE records in checkIfPageIsHidden
Description
The `checkIfPageIsHidden` queries the page and afterwards performs the workspace overlay.
However the first query can also load workspaced records, because the restriction is missing, which means changes in the workspace can affect the preview functionality of LIVE.
Most of the times this won’t break, because of the `LIMIT 1` and normally in the database the WS records will be stored after the LIVE record.
We first identified this bug in TYPO3 v10, where this bug is in `TypoScriptFrontendController`: https://github.com/TYPO3/typo3/blob/11.5/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php#L852
There you can see there is a check for `pid > 0` in the query which is the legacy way of saying “no workspace version”.
This issue was automatically created from https://github.com/TYPO3/typo3/pull/380
Reviews 1
History 28
-
Gerrit Code Review pushed patch set 1 for main to change 74680 status
NewUnder Review <span data-processor="relativetime" data-value="2022-05-18T14:06:42+00:00" > 05/18/22, 14:06 </span> -
Riccardo De Contardi changed category <span data-processor="relativetime" data-value="2022-05-28T14:20:42+00:00" > 05/28/22, 14:20 </span>
-
Gerrit Code Review pushed patch set 2 for main to change 74680 <span data-processor="relativetime" data-value="2022-07-16T21:29:26+00:00" > 07/16/22, 21:29 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 74680 <span data-processor="relativetime" data-value="2022-07-16T22:06:50+00:00" > 07/16/22, 22:06 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 74680 <span data-processor="relativetime" data-value="2023-05-03T09:52:01+00:00" > 05/03/23, 09:52 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 74680 <span data-processor="relativetime" data-value="2023-07-08T12:03:12+00:00" > 07/08/23, 12:03 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 74680 <span data-processor="relativetime" data-value="2024-10-18T14:08:46+00:00" > 10/18/24, 14:08 </span>
-
Christian Kuhn commented and changed status
Under ReviewClosed <span data-processor="relativetime" data-value="2025-01-20T12:13:00+00:00" > 01/20/25, 12:13 </span>
patch has been abandoned in review system as no longer reproducible by author.