Review 11.5 Merged

74761[BUGFIX] Make schedulable commands field identifiers unique

Oli Bartsch CR +2 V +2 Normal +96 −5 updated 05/31/22, 12:03

Commit message

The scheduler module contains a special task,
which allows to select schedulable symfony
commands.

The corresponding field provider therefore
adds the commands' configured arguments
and options. Due to insufficient prefixing, it
was not possible to display arguments and
options with the same name. Additionally,
using "action" as name always overwrote
the "select schedulable commands" field.

This is now resolved by adding proper prefixes.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Oli Bartsch commented on patch set 1 05/31/22, 10:11

    Cherry Picked from branch main.
  2. Oli Bartsch uploaded patch set 2 05/31/22, 10:13

  3. core-ci voted on patch set 2 V +1 05/31/22, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27595

  4. core-ci voted on patch set 1 V -1 05/31/22, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27594

  5. Oli Bartsch voted on patch set 2 V +2 CR +2 05/31/22, 12:03

  6. Oli Bartsch merged patch set 3 05/31/22, 12:03