Review 11.5 Merged

74840[TASK] Avoid failing test value for PHP 8.1.7 strtotime bug

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 06/10/22, 19:11

Commit message

PHP 8.1.7 introduced a bug that it considers the month number 100
to be valid, which breaks one of our tests.

As it is not relevant for the test whether the invalid month is
exactly 100 or 99, we now are using a number that does not trigger
the PHP bug.

https://github.com/php/php-src/issues/8749

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Stefan Bürk commented on patch set 1 06/10/22, 18:17

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 06/10/22, 18:22

  3. core-ci voted on patch set 1 V +1 06/10/22, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27945

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 06/10/22, 19:11

  5. Stefan Bürk merged patch set 2 06/10/22, 19:11