Review main Abandoned

75035[WIP][TASK] Use FileInterface in type annotations where appropriate

Oliver Klee CR 0 V 0 Easy +2 −2 updated 08/25/24, 10:10

Commit message

Where possible, code should be developed against abstractions, not
against concrete implementations.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 814

  1. Oliver Klee uploaded patch set 1 07/05/22, 11:00

  2. Oliver Klee marked it work in progress 07/05/22, 11:01

  3. core-ci voted on patch set 1 V +1 07/05/22, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28661

  4. Oliver Klee uploaded patch set 2 V +1 03/11/23, 17:59

  5. core-ci voted on patch set 2 V -1 03/11/23, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38804

  6. Oliver Klee rebased onto patch set 3 V -1 07/26/23, 14:11

  7. core-ci voted on patch set 3 V -1 07/26/23, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44584

  8. Oliver Klee uploaded patch set 4 V -1 07/26/23, 14:28

  9. core-ci voted on patch set 4 V -1 07/26/23, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44585

  10. Oliver Klee uploaded patch set 5 V -1 08/08/23, 11:08

  11. core-ci voted on patch set 5 V -1 08/08/23, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45237

  12. Oliver Klee uploaded patch set 6 V -1 11/25/23, 13:32

  13. core-ci voted on patch set 6 V +1 11/25/23, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49921

  14. Oliver Klee abandoned the change 08/25/24, 10:10