Issue Task Closed

#97860Use FileInterface where appropriate

Oliver Klee 07/05/22, 10:37 updated 03/18/25, 10:29

Description

This is the class structure:

File extends AbstractFile implements FileInterface
ProcessedFile extends AbstractFile implements FileInterface

FileReference implements FileInterface

So we should check whether we could use FileInterface in the annotations in places where ProcessedFile|File is annotated to simplify things (and allow for easier mocking in tests).

Reviews 1

History 410

  1. Oliver Klee changed subject Use FileInterface in annotations where appropriate Use FileInterface where appropriate 07/05/22, 10:58

  2. Gerrit Code Review pushed patch set 1 for main to change 75035 status New Under Review 07/05/22, 11:00

  3. Gerrit Code Review pushed patch set 2 for main to change 75035 03/11/23, 17:59

  4. Benni Mack changed target version 06/05/23, 09:23

  5. Gerrit Code Review pushed patch set 3 for main to change 75035 07/26/23, 14:11

  6. Gerrit Code Review pushed patch set 4 for main to change 75035 07/26/23, 14:28

  7. Gerrit Code Review pushed patch set 5 for main to change 75035 08/08/23, 11:08

  8. Gerrit Code Review pushed patch set 6 for main to change 75035 11/25/23, 13:32

  9. Georg Ringer commented 03/18/25, 10:26

    request to close issue from author as he currently doesn’t plan to work on those issues.

    If you find the issue valid and want to work on that, feel free to comment or contact me on slack

  10. Georg Ringer changed status Under Review Closed 03/18/25, 10:29