Review 11.5 Merged

75053[BUGFIX] Cast folder name in tree provider to string

Andreas Kienast CR +2 V +2 Easy +1 −0 updated 07/05/22, 18:20

Commit message

The method FileStorageTreeProvider->getSubfoldersRecursively() iterates
an array of subfolders and prepares folder information based on the
iterated data.

This functionality has a minor flaw, thanks to PHP, in case a folder
is named with numbers only, PHP treats array indices as integer if they
can be parsed as such, leading to TypeErrors as the method
prepareFolderInformation() expects a nullable string.

The passed subfolder name is now cast to string to solve this issue.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 07/05/22, 18:11

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/05/22, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28678

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 07/05/22, 18:19

  4. Andreas Kienast merged patch set 2 07/05/22, 18:20