Review 11.5 Merged

75059[BUGFIX] Fix type annotations concerning storage folder identifiers

Stefan Bürk CR +2 V +2 Easy +12 −11 updated 07/07/22, 19:52

Commit message

Storage folder identifiers can also be int-like strings, which causes
them to automatically get cast to int when used as array keys.

Our types annotations need to reflect this in order to keep developers
and static analysis for taking those array keys to be always strings
(which can lead to type errors and has recently done so).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 34

  1. Stefan Bürk commented on patch set 1 07/07/22, 19:38

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/07/22, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28729

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 07/07/22, 19:52

  4. Stefan Bürk merged patch set 2 07/07/22, 19:52