Review 10.4 Merged

75142[BUGFIX] Skip resolving backpath for already absolute paths

Oli Bartsch CR +2 V +2 Easy +24 −2 updated 07/14/22, 14:41

Commit message

In case GU::createVersionNumberedFilename() receives
a file with an absolute path, no back path should be resolved
since the resolved path will always be invalid, which led
to no version number got added to the filename anymore.

This is now fixed by checking for the path being absolute.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Oli Bartsch commented on patch set 1 07/14/22, 13:56

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 07/14/22, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29151

  3. Oli Bartsch uploaded patch set 2 07/14/22, 14:15

  4. core-ci voted on patch set 2 V +1 07/14/22, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29153

  5. Oli Bartsch voted on patch set 2 V +2 CR +2 07/14/22, 14:41

  6. Oli Bartsch merged patch set 3 07/14/22, 14:41