Review 11.5 Merged

75147[BUGFIX] Do not lose Context in AbstractContentObject

Benni Mack CR +2 V +2 Easy +43 −0 updated 07/16/22, 08:13

Commit message

When AbstractContentObject is fetching ->getPageRepository()
but TSFE hasn't been fully initialized yet, the Context
from TSFE should be used, and not the global one.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 813

  1. Benni Mack commented on patch set 1 07/15/22, 15:20

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/AbstractContentObject.php
  2. Benni Mack commented on patch set 2 07/15/22, 15:20

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 07/15/22, 15:23

  4. core-ci voted on patch set 2 V -1 07/15/22, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29229

  5. core-ci voted on patch set 1 V -1 07/15/22, 16:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29228

  6. Benni Mack uploaded patch set 3 07/15/22, 17:28

  7. Benni Mack uploaded patch set 4 07/15/22, 17:30

  8. core-ci voted on patch set 3 V -1 07/15/22, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29232

  9. core-ci voted on patch set 4 V -1 07/15/22, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29233

  10. Benni Mack uploaded patch set 5 07/15/22, 17:46

  11. core-ci voted on patch set 5 V +1 07/15/22, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29234

  12. Benni Mack voted on patch set 5 V +2 CR +2 07/16/22, 08:13

  13. Benni Mack merged patch set 6 07/16/22, 08:13