Review 11.5 Merged

75214[BUGFIX] Use config.extTarget as fallback for HMENU external links

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 07/18/22, 22:05

Commit message

If a page of type external link does not have a "target" defined
the fallback should be used. This behavior has been changed in
#96470 so the fallback is not
used anymore as an empty string is also respected as a valid value
but should not.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 07/18/22, 21:33

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/18/22, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29340

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 07/18/22, 22:05

  4. Stefan Bürk merged patch set 2 07/18/22, 22:05