Review 11.5 Merged

75223[BUGFIX] Prevent duplicate page tree items when entry points intersect

Stefan Bürk CR +2 V +2 Hard +323 −50 updated 07/25/22, 23:24

Commit message

In a scenario, where a backend user has two entry
points, in which the second one intersects the first
one (is a direct sub-page), pages were shown
multiple times.

The reason behind this was, that inside
PageTreeRepository->groupAndSortPages() every page
was added regardless if it was already added in a
previous run. This is the case, when the same pages
are found in different depth levels.

E.g.

1 - Home (DB mount 1)
  2 - Page 1
  2 - Page 2 (DB mount 2)
    3 - Subpage 1 // will be added for level 2 and 3
    3 - Subpage 2

To prevent this, a guard clause was added, which
checks whether the page was already added by
comparing the uid value.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 3

Files 5

Review log 46

  1. Stefan Bürk commented on patch set 1 07/25/22, 21:15

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 07/25/22, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29517

  3. Stefan Bürk uploaded patch set 2 07/25/22, 21:50

  4. core-ci voted on patch set 2 V +1 07/25/22, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29521

  5. Stefan Bürk voted on patch set 2 V +2 CR +2 07/25/22, 23:24

  6. Stefan Bürk merged patch set 3 07/25/22, 23:24