Review 10.4 Merged

75224[BUGFIX] Prevent duplicate page tree items when entry points intersect

Stefan Bürk CR +2 V +2 Hard +323 −50 updated 07/30/22, 21:57

Commit message

In a scenario, where a backend user has two entry
points, in which the second one intersects the first
one (is a direct sub-page), pages were shown
multiple times.

The reason behind this was, that inside
PageTreeRepository->groupAndSortPages() every page
was added regardless if it was already added in a
previous run. This is the case, when the same pages
are found in different depth levels.

E.g.

1 - Home (DB mount 1)
  2 - Page 1
  2 - Page 2 (DB mount 2)
    3 - Subpage 1 // will be added for level 2 and 3
    3 - Subpage 2

To prevent this, a guard clause was added, which
checks whether the page was already added by
comparing the uid value.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 3

Files 5

Review log 813

  1. Stefan Bürk commented on patch set 1 07/25/22, 21:16

    Cherry Picked from branch 11.5.
  2. core-ci voted on patch set 1 V -1 07/25/22, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29518

  3. Stefan Bürk uploaded patch set 2 07/25/22, 21:51

  4. core-ci voted on patch set 2 V -1 07/25/22, 23:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29522

  5. core-ci commented on patch set 2 07/25/22, 23:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29522

  6. Stefan Bürk commented on patch set 2 07/26/22, 09:07

    Backport / Test found PostgreSQL sorting (deterministic?!) issue - this must be investigated. Seems "unrelated" - we will see.
  7. Stefan Bürk rebased onto patch set 3 07/29/22, 23:08

  8. core-ci voted on patch set 3 V -1 07/29/22, 23:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29707

  9. Stefan Bürk commented on patch set 3 CR -1 07/30/22, 00:16

  10. Stefan Bürk rebased onto patch set 4 07/30/22, 21:50

  11. core-ci voted on patch set 4 V +1 07/30/22, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29730

  12. Stefan Bürk commented on patch set 4 V +2 CR +2 07/30/22, 21:57

    Reply

    Done
  13. Stefan Bürk merged patch set 5 07/30/22, 21:57