Review 11.5 Merged

75226[BUGFIX] Fix PHP 8.2 issue

Christian Kuhn CR +2 V +2 Easy +6 −22 updated 07/26/22, 18:57

Commit message

Prophecy has a minor PHP 8.2 issue as reported
with https://github.com/phpspec/prophecy/issues/555

This seems to be triggered by willBeConstructedWith()
when SuT has constructors in its inheritance chain.

Luckily, we can simplify the test a bit and
circumvent the issue for now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn commented on patch set 1 07/26/22, 18:48

    Cherry Picked from branch main.
  2. Stefan Bürk voted on patch set 1 V +1 CR +1 07/26/22, 18:55

  3. core-ci voted on patch set 1 V +1 07/26/22, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29568

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 07/26/22, 18:57

  5. Christian Kuhn merged patch set 2 07/26/22, 18:57