Review 11.5 Merged

75456[BUGFIX] Add sd and hq YouTube preview image resolutions

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 02/01/23, 08:40

Commit message

The YouTube helper tries to fetch from highest to
lowest image for possible previews.
The "sd" and "hq" versions were missing while checking
for an available image and got added.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Nikita Hovratov commented on patch set 1 08/12/22, 20:30

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/12/22, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30124

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 08/12/22, 20:55

  4. Nikita Hovratov merged patch set 2 08/12/22, 20:56

  5. Daniel Goerz commented on patch set 2 02/01/23, 08:40

    This is a mildly breaking change, because the dimensions of the image is different for sddefault.jpg and hqdefault.jpg. See for example the "TYPO3 - Still here": https://img.youtube.com/vi/yiJjpKzCVE4/maxresdefault.jpg https://img.youtube.com/vi/yiJjpKzCVE4/sddefault.jpg https://img.youtube.com/vi/yiJjpKzCVE4/hqdefault.jpg https://img.youtube.com/vi/yiJjpKzCVE4/mqdefault.jpg If the preview images are used in the frontend this may break page layouts for Videos that do not have a maxresdefault.jpg as the second hit will now have wrong dimensions. Or am I missing something?