Review 11.5 Merged

75499[BUGFIX] Add resultArray reference for InlineControlContainer customControls hook

Oli Bartsch CR +2 V +2 Easy +2 −0 updated 08/24/22, 14:31

Commit message

InlineControlContainer allows to add custom controls
via a userFunc (hook). However, since the resultArray
was not passed to the userFunc, e.g. no JS module
could be added for the custom control.

This is now fixed by passing the resultArray by reference
to the userFunc.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 08/24/22, 14:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/24/22, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30420

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 08/24/22, 14:31

  4. Oli Bartsch merged patch set 2 08/24/22, 14:31