Review 11.5 Merged

75632[TASK] Avoid PHP8.2 related deprecation failure in unit test

Georg Ringer CR +2 V +2 Normal +41 −15 updated 09/06/22, 20:35

Commit message

With PHP8.2 setting dynamic properties has been deprecated. This
is also valid if it is set through unserialization and emits a
deprecation warning. Thus this fails hard in tests.

Thus one test fails, which is expclicitly testing unserialization
with invalid dynamic class properties.

This change moves the test to unitDeprecated tests, which will not
fail on deprecation warnings. This acts pre-patch to update PHP8.2
testing to `PHP8.2.0 RC1`.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Georg Ringer commented on patch set 1 09/06/22, 18:34

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/06/22, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30669

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/06/22, 20:35

  4. Stefan Bürk merged patch set 2 09/06/22, 20:35