Review 11.5 Merged

75651[BUGFIX] Fix hide/unhide inline control for a special case

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 09/16/22, 13:06

Commit message

In case an inline field doesn't define the "disabled" column
in its "showitem" list, a hidden checkbox is now rendered in
the expanded state. This is the same checkbox, which is
rendered, when the inline item is initially visited in the
collapsed state.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn commented on patch set 1 09/16/22, 12:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 09/16/22, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31189

  3. Nikita Hovratov commented on patch set 1 09/16/22, 12:40

    inline_2 was not backported for v11 styleguide. Should we just remove the AC Test?
  4. Christian Kuhn uploaded patch set 2 09/16/22, 12:42

  5. Christian Kuhn commented on patch set 2 09/16/22, 12:46

    removed the test backport.
  6. core-ci voted on patch set 2 V +1 09/16/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31191

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 09/16/22, 13:06

  8. Stefan Bürk merged patch set 3 09/16/22, 13:06