Review 11.5 Merged

76053[BUGFIX] Uninitialized properties in DebuggerUtility

Stefan Bürk CR +2 V +2 Easy +24 −2 updated 10/10/22, 13:05

Commit message

DebuggerUtility::var_dump() is commonly used to debug PHP classes.

We recommend hardening PHP classes by using typed properties in PHP
classes. Previously uninitialized properties resulted in a PHP exception
when passing the class instance into DebuggerUtility::var_dump.

Uninitialized properties will not be processed by
DebuggerUtility::var_dump anymore. Instead a label "uninitialized"
indicates that it has not been initialized at the time of debugging.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 10/10/22, 12:54

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/10/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32140

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 10/10/22, 13:05

  4. Stefan Bürk merged patch set 2 10/10/22, 13:05