Review 11.5 Merged

76055[BUGFIX] Ensure `DB Check`->`Full Search` module works with PostgresSQL

Stefan Bürk CR +2 V +2 Easy +38 −5 updated 10/10/22, 16:31

Commit message

PostgresSQL is really picky about types and used operators. Thus using
for example a `like` comparision on non string/text based fields fails
hard. Database errors like following indicates this issue:

>  Undefined function: 7 ERROR: operator does not exist:
>  smallint ~~ unknown

This changes implicit converts field data to a text representation
for PostgresSQL, if field is not compatible. In case of small/tinyint
fields a double cast is used, means casting to integer and then to
string before applying the like comparison on it.

The choosen solution is used to have a comparible behaviour against the
other supported dbms systems like MariaDB, MySQL and SQLite, also doing
a full search on all fields may be a bad decision. The whole search and
full-search across all types should be reconsidered generally.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Stefan Bürk commented on patch set 1 10/10/22, 15:53

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/10/22, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32148

  3. Stefan Bürk uploaded patch set 2 10/10/22, 16:17

  4. core-ci voted on patch set 2 V +1 10/10/22, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32150

  5. Stefan Bürk voted on patch set 2 V +2 CR +2 10/10/22, 16:31

  6. Stefan Bürk merged patch set 3 10/10/22, 16:31