Review 11.5 Merged

76496[BUGFIX] Keep existing baseVariants for site languages

Benni Mack CR +2 V +2 Normal +85 −6 updated 11/09/22, 09:06

Commit message

The backend UI does not support handling of baseVariants
for languages, however it is possible to define them
in the config.yaml of a site configuration.

However, when editing and saving a site, the baseVariants
manually defined were removed. This has now been changed,
as the baseVariants are kept when persisting
the site configuration via the UI.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Benni Mack commented on patch set 1 11/09/22, 08:12

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php
  2. Benni Mack commented on patch set 2 11/09/22, 08:16

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 11/09/22, 08:17

  4. core-ci voted on patch set 1 V -1 11/09/22, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33373

  5. core-ci voted on patch set 2 V +1 11/09/22, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33375

  6. Oli Bartsch voted on patch set 2 V -1 11/09/22, 08:46

  7. Oli Bartsch commented on patch set 2 11/09/22, 08:48

    SiteConfigurationController.php:839

    This seems to be unrelated
  8. Oli Bartsch uploaded patch set 3 11/09/22, 08:49

  9. Oli Bartsch commented on patch set 3 11/09/22, 08:49

    SiteConfigurationController.php:839 Reply

    Done
  10. core-ci voted on patch set 3 V +1 11/09/22, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33378

  11. Benni Mack voted on patch set 3 V +2 CR +2 11/09/22, 09:06

  12. Benni Mack merged patch set 4 11/09/22, 09:06