Review 11.5 Merged

76497[BUGFIX] Allow no values in selectCheckbox in DataHandler

Stefan Bürk CR +2 V +2 Normal +91 −14 updated 11/10/22, 09:24

Commit message

With Doctrine DBAL in TYPO3 v8, a default value for
various fields were added to avoid SQL errors (nullable),
setting them to their default value.

However, there is a culprit. When editing e.g.
be_users.file_permissions where you have selectCheckbox field
with all options, it was never possible to unselect all, as
the default value was then used.

Through some workarounds, DataHandler now checks
the modified records on the selectCheckbox type to not
fall back on the default value.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 46

  1. Stefan Bürk commented on patch set 1 11/10/22, 08:50

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/10/22, 08:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33440

  3. Stefan Bürk uploaded patch set 2 11/10/22, 09:13

  4. core-ci voted on patch set 2 V +1 11/10/22, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33444

  5. Stefan Bürk voted on patch set 2 V +2 CR +2 11/10/22, 09:23

  6. Stefan Bürk merged patch set 3 11/10/22, 09:24