Review 11.5 Merged

76613[BUGFIX] Speed up FormEngine with selective workspaceOL() calls

Benni Mack CR +2 V +2 Normal +126 −69 updated 11/14/22, 16:21

Commit message

BackendUtility::getPossibleWorkspaceVersionIdsOfLiveRecordIds()
is added to check for workspace versions within FormEngine
foreign_field logic to first fetch a list of all records
that have a versioned record within the workspace, and only
apply BackendUtility::workspaceOL() for these cases.

Without the patch, each live record triggers a database
query to resolve a possible workspace overlay. With the
patch, one query is done to see which records have
workspace overlays, only those are queried for overlays.
This reduces the number of performed queries a lot, since
typically only a small number of records are overlaid.

This only affects editing records in a workspace.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Benni Mack commented on patch set 1 11/14/22, 16:12

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/14/22, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33720

  3. Benni Mack voted on patch set 1 V +2 CR +2 11/14/22, 16:21

  4. Benni Mack merged patch set 2 11/14/22, 16:21