Review 11.5 Merged

76673[BUGFIX] Avoid accessing null-row

Christian Kuhn CR +2 V +2 Easy +8 −8 updated 11/17/22, 18:40

Commit message

With `fallbackType` set to strict, only translated content is rendered.

In AbstractMenuContentObject->sectionIndex content is fetched and
overlayed. Once there is an element untranslated, the record overlay
will return a $row = `null`.

To mitigate, move all left over access to $row inside
the guarded if-block.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn commented on patch set 1 11/17/22, 18:13

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/17/22, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33884

  3. Oliver Klee voted on patch set 1 CR +1 11/17/22, 18:32

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 11/17/22, 18:40

  5. Christian Kuhn merged patch set 2 11/17/22, 18:40