Review 11.5 Merged

76774[BUGFIX] Use correct ordering of nl2br & htmlspecialchars

Nikita Hovratov CR +2 V +2 Easy +3 −3 updated 11/22/22, 21:36

Commit message

The ViewHelper `f:format.nl2br` must be applied after
`f:format.htmlspecialchars()`.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Nikita Hovratov commented on patch set 1 11/22/22, 21:17

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Private/Partials/NewContentElement/MenuItem.html
  2. core-ci voted on patch set 1 V +1 11/22/22, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34082

  3. Nikita Hovratov uploaded patch set 2 V +1 11/22/22, 21:25

  4. Nikita Hovratov commented on patch set 2 11/22/22, 21:28

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 11/22/22, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34083

  6. Nikita Hovratov voted on patch set 2 V +2 CR +2 11/22/22, 21:35

  7. Nikita Hovratov merged patch set 3 11/22/22, 21:36