Review 11.5 Merged

77334[BUGFIX] Avoid double hsc() in NoneElement

Oli Bartsch CR +2 V +2 Easy +0 −3 updated 01/12/23, 13:47

Commit message

TCA "type=none" with "pass_content=false" (styleguide
elements basic none_2) or without pass_content at
all (styleguide elements basic none_4) double
encodes the value. Testable using styleguide with
some DB value like "l<u>i</u>p", which needs to be
manually put into DB since none fields do not persist
data using the backend.

Note pass_content=true is documented to not hsc()
the value at all, which is not true since TYPO3 v7, a
htmlspecialchars() is still applied.

Not encoding HTML is a potential security risk, so
the patch now only fixes the "pass_content=false" and
"not set" scenario to no longer double encode, and
another patch will remove the pass_content option in v12
entirely with a TCA migration and deprecation note
stating the option did not work since 2017 anyways.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 01/12/23, 13:20

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/12/23, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35723

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 01/12/23, 13:47

  4. Oli Bartsch merged patch set 2 01/12/23, 13:47