77475[TASK] Replace localization methods in `PageLayoutController`
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1319
-
Andreas Kienast uploaded patch set 1 01/18/23, 14:47
-
Georg Ringer commented on patch set 1 CR -1 01/18/23, 14:56
-
core-ci voted on patch set 1 V -1 01/18/23, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36101
-
Andreas Kienast uploaded patch set 2
CR -1V -101/18/23, 15:01 -
Andreas Kienast commented on patch set 2 01/18/23, 15:01
PageLayoutController.php:53Replyarg, you're right -
core-ci voted on patch set 2 V +1 01/18/23, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36105
-
Benni Mack commented on patch set 2 CR -1 01/19/23, 10:40
Plase don't. Let's just use PageRepository, which has internal runtime caches already, and let's get rid of this method altogether. -
Andreas Kienast uploaded patch set 3
CR -1V +101/20/23, 13:19 -
Andreas Kienast uploaded patch set 4 01/20/23, 13:22
-
core-ci voted on patch set 3 V -1 01/20/23, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36347
-
core-ci voted on patch set 4 V +1 01/20/23, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36349
-
Andreas Kienast updated the commit message in patch set 5
V +101/20/23, 13:48 -
core-ci voted on patch set 5 V +1 01/20/23, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36360
-
Andreas Kienast rebased onto patch set 6
V +101/25/23, 10:47 -
core-ci voted on patch set 6 V +1 01/25/23, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36603
-
Benni Mack voted on patch set 6 V +1 CR +1 01/27/23, 08:00
-
Oli Bartsch voted on patch set 6 V +2 CR +2 01/27/23, 08:08
-
Oli Bartsch merged patch set 7 01/27/23, 08:08
-
Oli Bartsch wrote 02/20/23, 12:55
Created a revert of this change as I032f50b6465fbe2c3bf157cd13b9e99e558084db
PageLayoutController.php:53