#99613Replace PageLayoutController->getLocalizedPageRecord()
Description
The method PageLayoutController->getLocalizedPageRecord()` is currently called thrice, fetching the same record all over again. The method can be safely replaced with PageRepository->getPageOverlay()@, which receives a caching functionality in #97525.
Reviews 5
- 11.5 77902Revert "[TASK] Replace localization methods in `PageLayoutController`"
- main 77759Revert "[TASK] Replace localization methods in `PageLayoutController`"
- 11.5 77760Revert "[TASK] Replace localization methods in `PageLayoutController`"
- 11.5 77620[TASK] Replace localization methods in `PageLayoutController`
- main 77475[TASK] Replace localization methods in `PageLayoutController`
Related issues 1
History 512
-
Gerrit Code Review pushed patch set 1 for main to change 77475 status
NewUnder Review 01/18/23, 14:47 -
Gerrit Code Review pushed patch set 2 for main to change 77475 01/18/23, 15:01
-
Andreas Kienast changed subject
Store localized page record in page module in cacheReplace PageLayoutController->getLocalizedPageRecord() description statusUnder ReviewIn Progress 01/20/23, 13:10 -
Gerrit Code Review pushed patch set 3 for main to change 77475 status
In ProgressUnder Review 01/20/23, 13:19 -
Gerrit Code Review pushed patch set 4 for main to change 77475 01/20/23, 13:22
-
Gerrit Code Review pushed patch set 5 for main to change 77475 01/20/23, 13:48
-
Gerrit Code Review pushed patch set 6 for main to change 77475 01/25/23, 10:47
-
Andreas Fernandez commented and changed status
Under ReviewResolved done0 %100 % 01/27/23, 08:10 -
Gerrit Code Review pushed patch set 1 for 11.5 to change 77620 status
ResolvedUnder Review 01/27/23, 08:29 -
Andreas Fernandez commented and changed status
Under ReviewResolved 01/27/23, 08:55Applied in changeset commit:df81e5c358e620efd6917e9fa2be6f372226b8b8.
-
Benni Mack changed status
ResolvedClosed 02/08/23, 16:04 -
Oliver Bartsch changed Related to #99992 02/20/23, 12:52
Applied in changeset commit:7e10d6b5a9ae84b7ae77db872e44198f49b0c544.