Issue Task Closed

#99613Replace PageLayoutController->getLocalizedPageRecord()

Andreas Kienast 01/18/23, 14:44 updated 02/08/23, 16:04

Description

The method PageLayoutController->getLocalizedPageRecord()` is currently called thrice, fetching the same record all over again. The method can be safely replaced with PageRepository->getPageOverlay()@, which receives a caching functionality in #97525.

Reviews 5

History 512

  1. Gerrit Code Review pushed patch set 1 for main to change 77475 status New Under Review 01/18/23, 14:47

  2. Gerrit Code Review pushed patch set 2 for main to change 77475 01/18/23, 15:01

  3. Andreas Kienast changed subject Store localized page record in page module in cache Replace PageLayoutController->getLocalizedPageRecord() description status Under Review In Progress 01/20/23, 13:10

  4. Gerrit Code Review pushed patch set 3 for main to change 77475 status In Progress Under Review 01/20/23, 13:19

  5. Gerrit Code Review pushed patch set 4 for main to change 77475 01/20/23, 13:22

  6. Gerrit Code Review pushed patch set 5 for main to change 77475 01/20/23, 13:48

  7. Gerrit Code Review pushed patch set 6 for main to change 77475 01/25/23, 10:47

  8. Andreas Fernandez commented and changed status Under Review Resolved done 0 % 100 % 01/27/23, 08:10

    Applied in changeset commit:7e10d6b5a9ae84b7ae77db872e44198f49b0c544.

  9. Gerrit Code Review pushed patch set 1 for 11.5 to change 77620 status Resolved Under Review 01/27/23, 08:29

  10. Andreas Fernandez commented and changed status Under Review Resolved 01/27/23, 08:55

    Applied in changeset commit:df81e5c358e620efd6917e9fa2be6f372226b8b8.

  11. Benni Mack changed status Resolved Closed 02/08/23, 16:04

  12. Oliver Bartsch changed Related to #99992 02/20/23, 12:52