77717[TASK] Eliminate double serialization in ApcuBackend
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
Review log 1623
-
TYPO3com uploaded patch set 1 02/06/23, 16:43
-
core-ci voted on patch set 1 V +1 02/06/23, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37184
-
Benni Mack updated the commit message in patch set 2
V +102/06/23, 17:11 -
core-ci voted on patch set 2 V +1 02/06/23, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37191
-
Benni Mack voted on patch set 2 CR +1 02/06/23, 18:48
-
Andreas Kienast rebased onto patch set 3
CR +1V +102/06/23, 18:58 -
core-ci voted on patch set 3 V +1 02/06/23, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37208
-
Andreas Kienast voted on patch set 3 CR +1 02/06/23, 19:10
-
Stefan Bürk commented on patch set 3 CR -1 02/07/23, 13:59
I would love to see some additional tests, which tests for non-string data. The whole ApcuBackendTest only tests with strings. That was okay as only string has been supported. ALso testing for the exception has been missing. VariableFrontendTests are done against database backend - so ensuring the backend is really returning was had put into should be covered. -
Stefan Bürk commented on patch set 3 02/07/23, 14:00
Reply
And I wonder why if this may be "breaking" - given, on a update all caches should be cleared this may be IMO not really breaking. Just not sure. -
Christian Kuhn uploaded patch set 4
CR +1V +102/13/23, 15:22 -
Christian Kuhn commented on patch set 3 02/13/23, 15:28
Reply
not breaking, but removed v11 nevertheless. -
Christian Kuhn updated the commit message in patch set 5 02/13/23, 15:28
-
Christian Kuhn voted on patch set 5 V +1 CR +1 02/13/23, 15:29
-
Andreas Kienast commented on patch set 5 02/13/23, 15:34
ApcuBackend.php:26Que? -
Christian Kuhn uploaded patch set 6
CR +1V +102/13/23, 15:47 -
Christian Kuhn commented on patch set 5 V +1 CR +1 02/13/23, 15:47
ApcuBackend.php:26ReplyDone -
Christian Kuhn voted on patch set 6 V +1 CR +1 02/13/23, 15:47
-
core-ci voted on patch set 4 V +1 02/13/23, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37652
-
core-ci voted on patch set 5 V +1 02/13/23, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37654
-
core-ci voted on patch set 6 V +1 02/13/23, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37655
-
Stefan Bürk voted on patch set 6 V +2 CR +2 02/13/23, 18:15
-
Stefan Bürk merged patch set 7 02/13/23, 18:15