#99851Cache/ApcuBackend: eliminate double serialization
Description
APCu can store arbitrary PHP data; it serializes all values when they are stored, and it has a pluggable serializer interface which can use serializers that are better than serialize(), such as “igbinary” (https://www.php.net/manual/en/book.igbinary.php and https://pecl.php.net/package/igbinary).
By not implementing TransientBackendInterface, the ApcuBackend forces class VariableFrontend to serialize all values into a string, but APCu serializes the string again. This is unnecessary overhead.
This adds TransientBackendInterface and removes the is_string() check. Double serialization is eliminated by this change.
This issue was automatically created from https://github.com/TYPO3/typo3/pull/417
Reviews 1
History 28
-
Gerrit Code Review pushed patch set 1 for main to change 77717 status
NewUnder Review 02/06/23, 16:44 -
Gerrit Code Review pushed patch set 2 for main to change 77717 02/06/23, 17:11
-
Gerrit Code Review pushed patch set 3 for main to change 77717 02/06/23, 18:58
-
Gerrit Code Review pushed patch set 4 for main to change 77717 02/13/23, 15:22
-
Gerrit Code Review pushed patch set 5 for main to change 77717 02/13/23, 15:28
-
Gerrit Code Review pushed patch set 6 for main to change 77717 02/13/23, 15:47
-
Anonymous commented and changed status
Under ReviewResolved done0 %100 % 02/13/23, 18:20 -
Benni Mack changed status
ResolvedClosed 01/30/24, 09:06
Applied in changeset commit:f54531dad88addc4639f09b4cc37228524156d0c.