Review 11.5 Merged

77961[BUGFIX] Allow POST requests in Workspace previews

Benni Mack CR +2 V +2 Easy +3 −7 updated 03/01/23, 12:28

Commit message

With TYPO3 v9 and site handling, and speaking URLs
that are supported in workspaces, there is no technical
reason to avoid POST requests in Workspaces.

This limitation was added by Kasper in TYPO3 v4.0
in the infamous "tslib_fe" class, whereas the current
code base is much more structured and we can
now safely say, that we have Cookie handling
and POST requests under control via Site Handling,
and middlewares.

This way, forms can be tested and submitted in Workspace
previews.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2

Issues 1

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 03/01/23, 10:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 03/01/23, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38258

  3. Oliver Klee commented on patch set 2 V -1 03/01/23, 12:19

    Published edit on patch set 1.
  4. Oliver Klee voted on patch set 2 CR +1 03/01/23, 12:21

  5. Benni Mack voted on patch set 2 V +2 CR +2 03/01/23, 12:22

  6. Benni Mack merged patch set 3 03/01/23, 12:22

  7. core-ci voted on patch set 2 V +1 03/01/23, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38262